GuySten
GuySten
Fixed by #3533.
Maybe you could move the particle forward a TINY_BIT after it crosses the surface and then split it?
I thought about your points about analytic vs stochastic route and I think another way is a hybrid approach. Implementing the stochastic method as the default method and overriding the...
I am marking this as draft until I pass all tests and finish testing and bugfixes.
I integrated now the stochastic route and testing that uses it. This pr will be ready when I will add the regression test with spherical shape and Mixture energy distribution....
This pr is ready now for review.
I found the issue by debugging why a huge reactor model crashed when using distribmats. I traced the bug to the fact that in that model the function cell_instance_at_level from...
I had local regression tests failing after adding the lines: https://github.com/openmc-dev/openmc/blob/6eab5dbdee234d104b974b7006d03cb39a4cc688/src/geometry_aux.cpp#L434C1-L455C2 Specifically I remember that the distribmat regression test was failing after adding the check above.
@pshriwise, you have access to shaikinast/SPERT#8 so maybe you can review this pr?
I thought about another simplification to the distribcell logic. We can make cell.n_instances a function that will call universe.n_instances and store universe instance count instead of cell instance count. This...