GunSmoker
GunSmoker
Fixed code formatting, except for extra parenthesis. Your guidelines says it is allowed: "Add parentheses as appropriate to make things improve readability (even if not syntactically required by operators precedence)"....
@badfiles What exactly I should be looking at?
@badfiles Are there cat pictures or something?
If someone could indicate what is wrong with passing tests - it would be greatly appreciated. I can not reproduce these locally.
@dregad > Meaning what, you can't run the PHPUnit tests ? Or they run but give different results ? I tried to run phing. It gives: "Buildfile: build.xml does not...
@atrol > changes in manage_user_page.php are not related to this PR These are not mine. I think I have messed up when trying to keep my clone up to date...
@vboctor > Do we really need a db change vs. generate tokens from hashes. Technically, I can use something like signature: token = SHA1(bugid + server-secret), but that means that...
@dregad I think I have fixed the problem with tests. It was my mistake. Thanks for your help!
@cproensa @vboctor You do not like changes in auth API, which I can fully understand. However, you are suggesting to make analog of anonymous_account setting. But this setting is checked...
I have removed safe-guard checks from auth API. Seems to work OK, but someone with a deep knowledge of auth API should really get a look.