Guilhem Niot comments

Results 139 comments of


                                            Guilhem Niot

aop-bundle update to 1.2.0 breaks php app/console cache:clear

It doesn't seem to be related to `JMSAopBundle`... You can see the changes done in 1.2.0 [here](https://github.com/schmittjoh/JMSAopBundle/compare/1.1.0...master). Did you update another package at the same time?

Symfony\Component\DependencyInjection\Definition::getFactoryClass method is deprecated since version 2.6 and will be removed in 3.0

Fixed in https://github.com/schmittjoh/JMSAopBundle/pull/34

PHP 8 support

I could merge a PR, but this bundle is no longer actively maintained and I unfortunately won't have time to make the necessary changes myself.

Symfony 4 support

Well there is no plan to, we need someone enough motivated + has the time to create a PR. > What is missing here to work with version 4? This...

Issue#282: call setContainer on ContainerAwareInterface

Is this ready to merge? Or are there still some things to cover with tests?

Parent definition does not exist

ping @greg0ire

Use String as Parameter

what do you think @schmittjoh ?

How pass arguments without the need of override the constructor

Well this makes new annotations to support for a very small benefit...

add support for multiple service annotations

I'm wondering if we should not create a new `ServiceMetadata` class or just use the `Definition` class directly...

add support for multiple service annotations

@schmittjoh What do you think about having a new metadata class ? something like `ServiceMetadata` which would contain all the linked fields instead of having an array.