Guest257351
Guest257351
This is the most recent commit and the main branch, I should have said this earlier and im sure it's what caused the error, but I ran this inside of...
> I know very little about Lua byte code, but having separate patterns for each version of Lua makes dealing with problems like this a pain. Instead of checking every...
Just added a commit for a separate similar bug. I forgot to include this in the initial pull request. It's also worth noting that the number of bytes in the...
> I just checked the sample Lua 5.1 sample that is used in unit tests and the string is preceded by a 64 bit integer holding its size. The change...
> > The unified pattern you sent does seem to account for size_t's variable size, so I guess this was an issue specific to the lua 5.1 pattern. I'll update...
Also I'm not sure how I'd easily make either the unified version or the 5.1 version account for this. Ideally `LuaString` should use a `u32` if `LuaBinaryHeader.size_of_size_t` is 4, and...
> something like this should work: create a global > > ```c++ > u8 global_size_of_size_t=4; > ``` > > we assign a default just in case. Then inside header, right...
> Why are you only fixing lua 5.1? Are the other Luas also not possibly erroneous? Considering that we have to deal with 4 versions, there should be an attempt...