Simon Sawicki
Simon Sawicki
All right, I am composing a testing suite for the cookie parsing, derived from the CPython tests. Will push the tests to `test/test_InfoExtractor.py` when they are done.
Extracting the class immediately seems to make more sense, potentially placing it into `cookies.py` (with the tests moved to `test_cookies.py`)? Or should the class reside within `common.py` for now?
It is not a defect but a design choice as the comment in the code suggests, and lenient describes the behavior of the cookie accurately.
Do you know exactly which of the servers do not work currectly? Having a list one might be able to craft the correct solution.
> So I copy the function code in the file ? No, you use the functions provided by Python, for example the `chr` builtin instead of `compat_chr`. Compat functions were...
> The information in the "more info" tab would lead me to believe that there is something different about each file: `VOF-STE_ESP_-program_audio_0-VOF mp4 audio only │ m3u8 │ audio only...
On the contrary I would like to use the same cache for different workflows. Instead of overwriting `GITHUB_WORKFLOW` I would want to allow specifying the full container name: ```diff diff...
You can overwrite the `close` method on the buffer, so YoutubeDL doesn't close it and you can keep using it as a file, like ```py old_buffer_close = buffer.close buffer.close =...
I also think doing it that way is cleaner. What bad design does this provoke?
> Please see it as a suggestion or POC. Since your conversation shows how opinionated implementation details can be, you will probably come up with a better solution on your...