Grant Gryczan

Results 40 comments of Grant Gryczan

Frankly, if I were to try to fix this myself, I don't know where I'd begin to look, nor what I'd do once I find what I'm looking for. I'm...

I've definitely found the cause of the issue. It's in https://github.com/vega/ts-json-schema-generator/blob/next/src/Utils/deepMerge.ts. This screenshot alone should have all of the information necessary to see what's wrong. ![image](https://user-images.githubusercontent.com/14056899/143203101-8b4a77ba-7268-47ee-bbd0-eb9f95434a79.png) Based on the values...

That same breaking commit also removed a `deepMerge` test for `it("merges objects", ...)`. Not sure why. That test should probably be added again; it seems to be relevant here. (Though...

It's worth noting that the original version didn't merge arrays correctly, at least in this case. The `required` array would be empty rather than containing both `"b"` and `"c"`.

Oh okay, I asked because I was under the impression you were still trying to fix it yourself. Was wondering if you ran into complications or something.

I don't know what you mean. Perhaps you misread the issue? This is an actual problem during development when I haven't put commands in every function I've created yet as...