Gnuxie

For context; Currently the only way watched lists are audited when changed by another user is with https://github.com/matrix-org/mjolnir/blob/main/src/Mjolnir.ts#L971 For bus factor: The problem goes a lot further than improving auditing,...

Oh, that cause does make things a lot easier to understand on our end. Thanks for doing the follow up and investigating!

Thanks!

Yes it does fail, but it will be intermittent (so it can pass, and in this case it seemed to most of the time) since sometimes the promise executor can...

It is not a problem with the test runner at all, it is just the nature of concurrency in JS. I don't know what you mean, but yes I think...

Because reportPromise can resolve because most of the time the report does get sent after the listener registered rather than before

then in the second version of the test, `reportPromise` does resolve before we finish awaiting the response from the web server when sending the report (which is awaited at the...

No because in the first version of the test, if the report sends before the listener is registered (ie the protection is registered) then we never resolve `reportPromise` because the...

well, it's not a false negative if what we are trying to test (that a report is received) never takes place

I believe this was because of loops like [this](https://github.com/matrix-org/mjolnir/blob/main/test/integration/roomMembersTest.ts#L288-L298). The loop can just be read more easily as something like: ``` while(!roomIds.each(roomId => this.mjolnir.protectedRooms[roomId])) { await new Promise(resolve => setTimeout(resolve,...