Deli Gong

Add a contribution guide

4

A contribution guide is missing presently. Let's find a good reference to start with.

Track down the wrong use of acquiring multiple locks

1

We may have the same issues as fixed in #116

/usr/bin/ranlib reports that libServer.a(Server.cpp.o) has no symbols

2

See the master's latest build on [travis](https://travis-ci.org/Zilliqa/Zilliqa/jobs/356244226#L2479). It seems just a warning that won't prevent building.

Throwing a string as an exception

2

Here's an example in the codebase. https://github.com/Zilliqa/Zilliqa/blob/1e39b692900b59fd4b1c23985512e2edc6ca6f62/src/libData/BlockChainData/DSBlockChain.cpp#L51 There might be more. We probably need to fix all of them and adapt all the catch statements.

Properly handle missing fields in constants.xml

1

The current behavior is crashing when an option is not available. ``` terminate called after throwing an instance of 'boost::exception_detail::clone_impl' what(): No such node (node.constants.TX_SUBMISSION_TIMEOUT) ```

Data race when calling gmtime

1

[`gmtime()`](http://en.cppreference.com/w/cpp/chrono/c/gmtime) may not be thread-safe, so the caller should properly use the lock to avoid data race. For example, in `LogGeneral()`, the lock at line 168 is acquired after one...

Data race on m_latestForwardBlockNum

4

The data member `m_latestForwardBlockNum` lacks some lock protection. https://github.com/Zilliqa/Zilliqa/blob/3c47506ca8302adcad8da7829c981557c60f6b17/src/libNode/Node.h#L150 The possible read and write of this variable can be found [here](https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/Zilliqa/Zilliqa%24+m_latestForwardBlockNum) and you may find that multiple message handlers `Process*`...

[Style Guide] Use clang-tidy option readability-identifier-naming for naming checks

1

Use `readability-identifier-naming` with its customizable options. https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/readability-identifier-naming.cpp

Missing and outdated dep install instructions in README.md

2

The dependency installation instructions in `README.md` tend to be incomplete or out-of-sync with the real need of the codebase when dependences are added or modified if we only rely on...

Indistinguishable logging levels for warnings and errors

1

The current logging level has some flaw: we only have `INFO`, `WARNING`, `FATAL` which are defaults from g3log and we didn't define customized levels such as `ERROR`. (see the discussion:...