Xiang Wang

Results 19 comments of Xiang Wang

Thank you guys for the time on this ticket. Since I am not working on this anymore, please feel free to close the ticket if needed.

Thanks @mmatczuk for the interest. I made a [PR](https://github.com/scylladb/gocqlx/pull/160) as a draft version for the purpose of POC. The code has't been carefully polished yet. Please just have a quick...

By the way, it would be helpful if you could share some suggestions on naming terminologies and variables.

Thanks. > We should use session.NewBatch, building it in qb has many shortcommings Would you please share some of the shortcommings?

The difficiences are below: 1. gocql.Batch has some more batch specific check, such as BatchSize(65535). 2. gocql.Batch use BatchObserver instead of QueryObserver. 3. gocql.Batch has cancelBatch call back. 4. gocql.Batch...

gocql.Batch cannot be "prepared" beforehand like what I do with gocqlx.qb.BatchBuilder because Query or Bind in gocq.Batch requires args immediately. Do you have any suggestions on what fields the new...

Can we postpone deprecating qb.BatchBuilder? If YES, should I go on the current entity batch implementation (pre-construct the stmt&names via qb.BatchBuilder)?

May I go on using qb.BatchBuilder to implement this MR?

I am thinking whether I can keep using qb.Batchbuilder for this MR. The biggest cons of using the current qb.BatchBuilder instead of gocql.Batch is the overhead of "prebuilding" a batch's...