Gideon Potok
Gideon Potok
@uros-db This is ready for the initial round of review. Let me know what you think!
> Can you fill the PR description please @HyukjinKwon done.
@cloud-fan @MaxGekk @dbatomic just letting y'all know this is ready for first round of review. Thanks!
> kudos for your effort on this ticket! I left some comments > > also, please try to ensure that your code doesn't introduce any breaking changes (for example, I...
> just another quick note based on your previous PRs - no need to force push and disrupt the commit history, in general I think it's easier to follow changes...
@uros-db This is ready for initial review. Let me know what you think. I am working on simplifying the implementation -- suggestions for how to do so are welcome. All...
> left some comments, code structure looks much better than before in my opinion > > let's just clean this up a bit - not leave behind any comments from...
@uros-db , I just wanted to loop you in that I am just going to put finishing this PR on hold for like two weeks while I attend to some...
@uros-db I think this is ready for re-review lmk what you think. The one thing I have to do is add a comment about following up with maptype. Where should...