Nicholas Winterhalter

> I have no idea why this is different in vanilla vs PM. If anyone wants to investigate this, please feel free. idk actually that everything is very strange. maybe...

better then rename it to registerEvent => registerEventHandler registerEvents => registerEventsListener i think, it becomes more understandable than just "registerHandler" and "registerListener", idk. if we think about fact, that these...

> Seems to me like this violates the MONITOR priority's expected conditions (that the event won't be modified on or after MONITOR). what if we use sofe's mutex for this?

> Seems to me like this violates the MONITOR priority's expected conditions (that the event won't be modified on or after MONITOR). something like mutex to be right

> > Seems to me like this violates the MONITOR priority's expected conditions (that the event won't be modified on or after MONITOR). > > something like mutex to be...

> @Gewinum the problem is that you can't guarantee that handlers use the mutex what if we call playerchatevent and check every listener? after calling every playerchatevent we wait for...

> @Gewinum the problem is that you can't guarantee that handlers use the mutex yeah, my solution could have some type of latency but does it matter with playerchatevent by...

> I don't love that we're breaking BC to implement this. Is there a way to do it while retaining BC? sometimes sacrifices are to be made

> I don't love that we're breaking BC to implement this. Is there a way to do it while retaining BC? the change he made(getnetworktypeid) is done in pm6, isn't...

phpstan is so aggressive