George

```go package "controlplane" type Repository interface { // ... CancelRun(id string) error } ``` The cancel run action on the control plane should command a run to stop, interrupt inflight...

Add failing test for formatting integer

1

This isn't strictly a pull request. More a demonstration of an issue I am observing. When formatting some integers using `%d`, I am finding incorrect results for certain inputs. I...

Concurrency Section Improvements

1

What I think we need to add in order to feel that [concurrency](/codeship/go-best-practice/tree/master/concurrency) is complete for now. - [x] supervising goroutines (e.g. tracking them with wait groups or communicating with...

Testing Section Improvements

3

What I think we need to add in order to feel that [testing](/codeship/go-best-practice/tree/master/testing) is complete for now. - [x] mocking and interfaces - [ ] integration testing - [ ]...

Design Pattern Best Practices

2

We need a section on design pattern best practices

We need a section on writing documentation.

We need a section on project structure best practices

Updating `/api/v2/checks` to enforce `orgID` parameter as per spec: https://github.com/influxdata/influxdb/blob/master/http/swagger.yml#L5505-L5510 I've had a look around and can't find anywhere that doesn't already consume this API in this way. Not enforcing...

feat: add a workflow to enforce non-empty PR or Issue descriptions

1

This adds a Github action which ensure that both pull requests and issue bodies have descriptions with at least 1 character in them. The action is a little militant as...

Fixes #2789 Remove the call for `toLowerCase()` from the stringAsKey function as upper-case letters are acceptable in keys.