Gargi Jaiswal
Gargi Jaiswal
@cchung100m Please add a unit test in `TestContainerUtils` for the following scenario: 1. Setup storage directory structure 2. Create VERSION file with datanode UUID 3. Simulate corrupted/empty datanode.id file. Creates...
@ChenSammi and @peterxcli Could you please review the patch?
@ChenSammi Please have a look on this patch. I have resolved the review comments.
> AWS S3 reference [says](https://docs.aws.amazon.com/AmazonS3/latest/API/API_AbortMultipartUpload.html#API_AbortMultipartUpload_Errors) NoSuchUpload should return 404. You are correct but if you see this NoSuchUpload exception is used at multiple places were it should return 404, that's...
> The discussion you mentioned says AWS is inconsistent and returns 404 after 24 hours. I did noticed this statement as well which is opposite and makes it naunced.
> > The discussion you mentioned says AWS is inconsistent and returns 404 after 24 hours. > > I did noticed this statement as well which is opposite and makes...
I believe that the behavior of `204 No Content` for an already-aborted upload is not legacy behavior tied to eventual consistency. The goal of `AbortMultipartUpload` is to ensure the upload...
> I think for 204 vs 404, we might need to check these two cases: Abort multipart upload that was initiated before (i.e. it exists before): This might return 204...
> I think the best way for us to check is to simply create a real AWS S3 account and verify the behavior. Since the official AWS S3 documentation only...
> @Gargi-jais11 I'll get back to you with my own AWS S3 testing first. @ivandika3 just wanted to check in regarding the AWS S3 testing for `AbortMultipartUpload` behaviour. Please share...