Dobin Shin

Results 12 comments of Dobin Shin

can you add the version of recoil-persist you use?

When will support for React 19 be available? If it's just a matter of adding `^19.0.0` to peerDependencies in the `lucide-react/package.json`, can I submit a PR for that?

as the error says `lucide-react` peer dependency mismatch with react 19 downgrading to 18 could be a solution or use `--force` `--legacy-peer-deps` flags to npm install

lucide-react now supports `"react":^19.0.0` but not rc(release candidate) https://github.com/lucide-icons/lucide/issues/2134#event-13293674013

@shadcn Would you mind looking into it?

@shadcn Thanks for the good library you made, our company is really using well. Would you please look into this PR?

I have migrated v1 to v4, had same concern so it will really help. If not knowing that the versions are kept. Had to ran a big quality assurance test.

You're right, the reason I missed it is probably because I'm not a native English speaker. Agree that the issue can be closed.

Hello @Snailman11 @DayKev Can I try this issue? Or is it taken?

@Bertie690 I added a test to check the order of stat changes. (https://github.com/pagefaultgames/pokerogue/pull/5936/commits/400733442e284081d6650dcc08440f3bdaddaa4f, attack falls first then speed increases) It would be nice if there was a test for when...