Gabriel Valfridsson

Results 8 comments of Gabriel Valfridsson

I opened another issue that might or might not be related. The error message is the same and it also started happening in the latest couple of versions. It has...

The fix for my issue is not in any release yet. It was merged 2 days after 4.5.4 was released. Staying on earlier version of linaria works fine for me...

I get errors from all commits newer than a4263c4558ca092293e43689ab5501c3098fab84 Test procedure: ``` git clone https://github.com/callstack/linaria.git cd linaria git checkout commithash pnpm bootstrap cd ../ourproject npm link ../linaria/packages/babel/ ../linaria/packages/core/ ../linaria/packages/logger/ ../linaria/packages/react/...

The only errors i get using that branch is react-modal claiming the element doesn't exist when this line execute during eval `Modal.setAppElement('#someid');` and another error in the same module saying...

Doesn't this break rusts safety guarantees or am i missing something? What prevents me from dereferencing a Box in another thread or after the scope has ended?

Marking the scoped api unsafe would be correct but would give the user of the api the impossible task of verifying that no code within the callback violate the safety...

I don't think there is any issue with getOptimisticResult. It'll only be called once in my scenario. It then doing N operations is fine as it only leads to O(N)...

Looking at the code myself and at your PR @joseph0926 I realized that this will be quite hard to solve entirely. Your PR does remove some quadratic work but onUpdate...