Graham Esau

Results 90 comments of Graham Esau

Thanks @teozkr, I've created a new change based on this one in #167. I made it use the `#[serde(bound = ...)]` value if it's not overridden by a `#[schemars(bound =...

> I have run into this issue as well. It seems that `schemars` forcibly re-wraps every paragraph _somehow_ such that code blocks end up on a single line. I'm not...

I like the idea of this, although I'd rather not make the built-in impls "special" by having only them include the rust type in the schema - I'd rather it...

Having said that, if this were done for all types, maybe it should "see through" references and `Box`s etc. Otherwise we could get into strange cases like: ```rust struct MyStruct...

My first thought is that it should be possible to implement `OpenApiFromFormField` for `TempFile` without it implementing `JsonSchema`, indeed this is [already done in okapi](https://github.com/GREsau/okapi/blob/1740ebc59ff1135ea4e0c4bc73a14cf99e5e8413/rocket-okapi/src/request/from_data_impls.rs#L82-L86). But after looking into it...

Rocket also allows renaming fields (and setting defaults) in `FromForm` derives - [see docs](https://api.rocket.rs/master/rocket/derive.FromForm.html). It would be nice if okapi/schemars also respected that, but that's a separate issue entirely.

Currently schemars ignores any attributes on a field of a struct with `#[serde(transparent)]`, which definitely could be considered a bug. Although in this particular case, I'm not sure you actually...

That's true, what I should have said was schemars ignores _most_ attributes on a field of a struct with `#[serde(transparent)]`. `with`/`schema_with` are notable exceptions to this

I think I prefer the `[schemars(extension("x-foo-bar" = "baz"))]` syntax I suggested in #50, as it feels like a cleaner interface to adding extensions - at least when the keys of...