Nithish Reddy Banda
Nithish Reddy Banda
I have raised a PR in Localization Repo which completely fixes the issue Thanks for the PR @smarizvi110.
Hey @arougey Could you run the tests, just want to make sure there are no static and lint errors Thanks.
> The video in your PR description appears to be broken. Can you add some before/after screenshots instead? Sure Thanks for pointing it out. Added before/after screenshots for both instructor...
hey @shailpatels I have created a branch named "team-constraint-origin" from the branch "team-constraint" which you have created and merged with main Hope this resolved all of the issues regarding the...
> Thanks for the PR! And sorry again for destroying the original one, forks on github are still weirdly confusing 😅 > > Changes look good and works as described...
sorry for multiple commits. you may go through above @williamjallen and state further changes Also, please note that : 1. hasSpecialCharacters function will not check for emoji characters 2. The...
> > 1. hasSpecialCharacters function will not check for emoji characters > > 2. The long regular expression checks for significant amount of emojis out there. > > Instead of...
Hey @chenjohnny-cs, can you please run the tests Just want to make sure, there are no lint errors/ cypress test fails. Thank you.
> > Hey @chenjohnny-cs, can you please run the tests Just want to make sure, there are no lint errors/ cypress test fails. Thank you. > > Sure, should be...
> Approving again after retesting for the requested changes, thanks for the PR! thanks for the approval! So @shailpatels , could you please merge this PR as the issue's been...