GCHQDev404

Results 51 comments of GCHQDev404

Branch has been refactored, JobTracker cache has been changed to accept a naming suffix the same as FederatedStorageCache. Please examine https://github.com/gchq/Gaffer/compare/gh-2457-double-caching-issue

This contains many breaking changes and will need to be reviewed before merging into V1 Gaffer. likely will need to be V2.

Review requesting Admin code coverage

No longer within the realm of FedStore but better suited to individual store implementations.

No longer within the realm of FedStore but better suited to individual store implementations.

I'm not understanding, I might be missing something fundamental here. Is the JSON serialiser not being used in this situation for storing to Disk Cache? In the examples you mentioned....

Ah, so with FederatedStore a cache was implemented `FederatedStoreCache` it is a wrapper for `CacheServiceLoader` and serialises `Pair`. String manipulation was handled their for graphs (which at the time wasn't...

As I understand it. We are in agreement that `FederatedStoreCache` can be modified to handle the manipulation of unserialisable `AccessPredicate` into cached strings and then retrieved back into `AccessPredicate` objects....

@d47853 It was a suggestion around minimising hash collisions. Since numbers given to Hashcode builder seem to be duplicated a lot in Gaffer. I'm happy for this ticket to be...

Migration The Old cache will not work because the name of the cache will not be found/used. Solution. delete the cache directory. turn on the FederatedStore it will be empty,...