Garrett Birkel

Results 15 comments of Garrett Birkel

I think this fixes a rendering issue we’re having with our recent merge at Demetrix...

I'm afraid this one may be beyond my skill to review. I'm not sure what the long-term consequences of changing `Object` to `ObjectRec` would be.

I got this to work, but you're not going to like the method... 1. Start with a UTM install of 10.7 built according to the config at https://github.com/adespoton/utmconfigs/blob/main/README.md (Getting 10.7...

This feature definitely didn't work for me until I made the above changes, along with the accompanying back-end PR. I could not successfully pass a return URL from the front...

That said, if it is breaking current deployments, go ahead and back it out. I'm using a fork for my own deployment and will just avoid pulling in master until...

https://github.com/SciCatProject/frontend/commit/d7bfbbb95f74548151f40683e47d0ac5ddb8814f#r162312535 This change breaks SciCat Live's config.json-merging feature in merge.json.sh, specifically the line apk update && apk add jq gettext, because apk does not exist on this image. https://github.com/SciCatProject/scicatlive/blob/57731e4bf81dd902f395dbe47a24a9039e2576cd/entrypoints/merge_json.sh#L5 https://github.com/SciCatProject/scicatlive/blob/57731e4bf81dd902f395dbe47a24a9039e2576cd/services/frontend/compose.base.yaml#L12...

I'm a bit late to the party here, but I just want to drop in and offer my endorsement for the "separation of concerns." I think we can all agree...

I've had more time to look over the code, and I believe the solution I described above is an ideal one. In default cases of a single front end hosted...

That looks like the right sequence, yes. I think there's one caveat when dealing with multiple front-ends: We need to fetch and read `/assets/config.json` / `/assets/config.defaults.json` first in order to...

> I prefer not to include any service-specific dependent code in the Scicat core, and instead provide a more generic solution. In this case, allowing users to provide arbitrary URLs...