Matus Goljer

Results 743 comments of Matus Goljer

Not really, my linux environment is really weird :D I use Xmonad as window manager on top of some form of xfce but nothing like a normal desktop environment. But...

I think this might cause problems because ISTR there are other properties stored which are needed by some other package. I will need to review this more properly.

Thank you, this is a good idea. In Emacs there is a macro `define-globalized-minor-mode` for making global modes. I think it might be a bit cleaner to use it to...

However, the bloat is invisible to the user and it adds a lot of value for maintenance.

I added the global mode using the macro `define-globalized-minor-mode` in dab22a3dcf3b40c3be0f981eff872199a552800b . Personally I feel like the consistency and maintainability outweighs some extra maybe unnecessary code which the macro generates....

Feel free to make a pull request to melpa! Thanks!

I wanted to add "Comment" review not "Request changes" as not all are requests for changes (only 3 or so). Good job overall, this is a very nice improvement!

I think it might be too aggresive to work on the whole tree. Sometimes people just want to remove the file and keep the hierarchy intact. To be fair I...

Hm. I find it quite peculiar that this package should cause something like that. How did you figure this package is the problem? The process would help with debugging.