Jerry Tan

Results 37 issues of Jerry Tan

This PR fixes https://github.com/sbt/sbt/issues/4125, https://github.com/sbt/zinc/issues/537. ### Issue When `@inline` method implementation changes, the public API of `@inline` method does not change, hence Zinc does not invalidate sources that depends on...

Fixes #1171 ### Issue When a macro takes some type parameter `T`, e.g. `def hasAnyField[T]: Boolean = macro hasAnyFieldImpl[T]`. Changes in `T` require macro client to be invalidated if macro...

Fixes other half of https://github.com/sbt/zinc/issues/1296 Validate the fix: (As shown in screenshot, smart IDE features are now working)

This PR fixes #1304, #963 ### Issue https://github.com/sbt/zinc/blob/5eb0de1fdfd921f0d1b6a9302fe42593e7e27922/internal/compiler-bridge/src/main/scala/xsbt/API.scala#L62 In certain codepath, `unit.source.file` is a `PlainFile`, which causes a `MatchError`. ### Fix When `unit.source` is built, convert `unit.source.file` to `ZincPlainFile`. ###...

Fixes #683 ### Issue `InitialStamps` assumes source files do not change during compilation, yet #683 states that they do in fact change. ### Fix Remove the source stamp cache in...

https://github.com/sbt/zinc/blob/1c809a60a11a710aa4b016aa28f7e8a44da68a98/internal/zinc-core/src/main/scala/sbt/internal/inc/IncrementalCommon.scala#L581-L610 Issue: It is hard to tell the purpose of `reInvalidated`. Ideally the need to include `reInvalidated` can be documented better. Preferably we can also add a unit test to...

This PR implements https://github.com/sbt/zinc/issues/932 via building `SourceInfos` from analysis callback and pass them to `handleErrors` in `CompilerBridge.scala`. c.c. @adpi2

In `Dependencies.scala`, the method name `processExternalDependency` seems to imply that the method handles only external dependency. However, it actually also handles internal dependency. Could we consider renaming this method to...

Scala 2.13 is significantly more popular than Scala 2.12, hence it would cover more demographics for Zinc Scripted Test to run with 2.13 by default instead of 2.12. [scala/scala](https://github.com/scala/scala) has...

For instance: `$$\dfrac{1}{x}+\dfrac{1}{y}+\dfrac{1}{z}=\dfrac{2}{n}$$` Is being flagged by spellcheck, while the formula is correct. If the developer feels like such feature should be added, then I am willing to devote my...

enhancement