Frank

Results 94 comments of Frank

@crkrenn -- Sorry for taking so long to get to this PR. I'm looking at testing it this morning.

Alright -- after some review, this appears to be functioning on my end. I tested the LULESH example locally. One thing that I did notice is that parameters are repeated...

@crkrenn @thecivicscenter -- I generated the above links from the root of the Maestro repository by running the following: ``` maestro run --make-links ./samples/lulesh/lulesh_sample1_macosx.yaml ``` That creates timestamped directories in...

Not a problem! Glad you were able to verify that the feature is working as intended. I think this PR is great for a first pass and we can revisit...

@crkrenn -- Added `jinja2` to `setup.py` -- we currently maintain that so that Maestro can be installed in editable mode, something that the toml file doesn't currently support.

> Hello again Frank, > > Reviewing, it looks like there were at least one question and suggestion: > > A question: should I keep the new code in utils.py,...

@crkrenn -- Thanks for the heads up, sorry it's taken me so long to get back. Do you mind rebasing this branch so that the CI can run? I recently...

@crkrenn -- I can do my best to look over this tomorrow; if not then, probably over the weekend.

> @FrankD412, (cc: @daub1) > > Thanks again for the careful review. > > Regarding: > > > 1. I ran with the defaults maestro run --make-links ./samples/lulesh/lulesh_sample1_unix.yaml. This appears...

@crkrenn -- I test this this morning and it appears to work. There we a number of newlines added to the help messages, so I pruned a good number of...