FranckQC comments

Repositories
Issues
Comments

Results 3 comments of


                                            FranckQC

[TIR, analysis] Add expr hash sort in ExprDeepEqual

Hello! Thank you for the discussion and the PR. Just a few thoughts here: - **1.** Indeed, we knew that the existing `Analyzer::Simplify()` would not deal with commutativity, because it...

[TIR, analysis] Add expr hash sort in ExprDeepEqual

> @FranckQC @masahi can you help to take a look Sure, will do on Monday if that's ok :)

[TIR, analysis] Add expr hash sort in ExprDeepEqual

I was finally able to take some time this week to have a closer look at this PR. It is definitely better than it was before, as it leaves the...