Daniel Fahlke

Results 92 comments of Daniel Fahlke

because it sounds relevant: http://blog.naderman.de/2014/02/17/replace-conflict-forks-explained/

I added a new testcase for triggering the autoloader for a non existing class https://github.com/OpenMage/Testfield/commit/ef1a4aee6ef402763d80fa216e3d4b616dddbb89 this test currently fails with this change. (which is the actual reason, why we added...

@woutersamaey no, the testcase imitates a common usecase. in other words: remove the @, and you break at least every M1 project I ever worked on

the testcase is pretty clear ``` public function testClassDoesNotExists() { $this->assertFalse(class_exists('Mage_Non_Existent')); } ``` using a class_exist() on a class which could not exist is a very normal thing in php....

> I vote for that, but I forgot if it works very well or not, and not deployed in production: > > ```diff > diff --git a/app/Mage.php b/app/Mage.php > index...

There are different kinds of BC breaks. They come with different reach, documentation, tooling, polifills. And for a theme, the framework does support modifying themes, or even copying them into...

You can add this more detailed exception as part of the existing exception by using the 3th parameter of the constructor https://www.php.net/manual/de/exception.construct.php which then can if needed be fetched via...

removing it completely is a serious BC break. (we also do not know, if people did misuse it in some way) We will probably not include it in Version 19....

> This looks like a much better solution. Should you use the original return value? > > ``` > return include $found; > ``` > > Maybe the return value...

nice page, but probably scraped from an old version. The [readme](https://github.com/Cotya/magento-composer-installer#auto-add-files-to-gitignore) now says you have to explicite enable it, and it does not mention cleanup after uninstall. I remember we...