Lorenzo Moscati
Lorenzo Moscati
After further inspection of the code I am quite confident that the entirety of the src/bitBetter folder can now be removed. At this point I think that the work left...
I tested out the latest code and unfortunately we were wrong about the certificate fingerprint: at some point it is very much needed! (I can't tell when unfortunately) If you...
Also I think we need to update the `.gitignore` so that the `server` folder fetched from the `bitwarden/server` repo is not tracked by git
Great catch. As of now I think the PR can be considered done, as long as no one else is willing to test this implementation more thoroughly. Just a minor...
Before calling it a day, I'd like to share a thought that I had in mind regarding this solution: Until the last version the BitBetter code was in fact modifying...
@captainhook @h44z What's your take on this PR? Ready to be merged?
In the meantime I had the time to dig a bit into the bitwarden/server repo's commits and I think I found the commit that broke BitBetter: [bitwarden/server@63f5811aa9475aea9ecbcbe73e20cf1aefb6ca08](https://github.com/bitwarden/server/commit/63f5811aa9475aea9ecbcbe73e20cf1aefb6ca08) You can clearly...
Interesting observation. @Genva do you think you'd be able to open a draft PR? Maybe with some starting code I'd be able to help at least testing some things out
The support for ES256 (and possibly 384/512) would be a really nice security improvement.