Raghuram Kannan
Raghuram Kannan
@notmandatory I would like to work on this, As far as I have understood I need to replace **enable_rbf** with **disable_rbf** in **tx_builder.rs**. This new function shouldn't initialize the value...
Is it okay to remove multiple rules in the same PR ?
> We already know that this causes failures, what are you trying to achieve with this change? How does it help with debugging? I created this PR mainly to keep...
Okay, I will start working on this right away.
> I strongly advice including integration test in this PR, since we already have it for v1. This would be the best proof that the setup works. Okay. I will...
> overall lgtm, but CI for v2 failed. Please test it locally first, it's fairly quick. > > ``` > time="2024-06-28T00:59:22Z" level=warning msg="/home/runner/work/jaeger/jaeger/docker-compose/monitor/docker-compose-v2.yml: `version` is obsolete" > jaeger-1 | 2024/06/28...
> You are missing the concept of "metrics storage", similar to span storage. It can be defined as part of query extension (as it's the only dependency), and you need...