Fiona Waters
Fiona Waters
Hi @asm582, just a question about this issue which I have started working on. Is it appropriate to update some functions to return errors, so that we can catch the...
> For future reference, the root cause analysis of the test's failure has been conducted by @dgrove-oss, and it can be found here: [#691 (comment)](https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/691#issuecomment-1832070420) Thanks @ronensc That's good to...
More investigation is required as to why these tests are failing. Closing this PR.
@swastik959 are you still interested in working on this issue? If not I would like to.
> @Fiona-Waters Are there any updates on this? I'm interested in using it for a downstream task. I was planning on writing something but thought I'd ask if there was...
> Very awesome job @Fiona-Waters ! I left a few nitpicks and the comment below > > I think this file should be addressed as well: > > https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/41833f2bd925d39e7391165d402e4df76025a296/pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go#L603 Thanks...
> @Fiona-Waters do we still see this issue with the main branch? @asm582 I haven't tested this with the main branch on OSD 4.13 again since creating this ticket. But...
Tested these changes through the SDK demo notebooks using quay.io/mcampbel/ray:220-py39-cu118-dev as the ray image. - Was able to run basic ray demo. - Was able to run job client demo...
/approve