Felix Schneider

Results 4 comments of Felix Schneider

@elizabetht It's a good start. I would prefer that vllm not modify basic methods on shared objects like sys.stdout and sys.stderr **under any circumstances**. Because those changes are not transparent...

> however it will typically spawn owned subprocesses (the core engine and GPU worker processes), and I think it's also reasonable to modify the stderr/out within these. I have to...

@njhill @elizabetht To keep the ball rolling on this: The proposed fix is better than the current state, so let's move forward with it.

> The [docs](https://docs.pydantic.dev/latest/api/base_model/#pydantic.BaseModel.model_fields_set) state: > > Returns the set of fields that have been explicitly set on this model instance. My understanding was that this means "model fields" and does...