Felix Herrmann comments

Results 59 comments of


                                            Felix Herrmann

Candle on CandleStickChartView always one

#4829 fixes that!

Fix bug in `XBounds` calculation of minimum/maximum visible entry index.

This conflicts with #4829 where I fixed the partitioningIndex algorithm change

Fix bug in `XBounds` calculation of minimum/maximum visible entry index.

My PR might fix your whole problem as you can see in the screenshot below! Could you test my [fork](https://github.com/FelixHerrmann/Charts) and confirm? ![image](https://user-images.githubusercontent.com/42500484/174618801-835fcf5f-5767-49b7-9aee-78307989ef59.png)

LineGraph is not showing up in CombinedChart

Hi, I'm pretty sure it's the issue I fixed in #4829. You can try out my [fork](https://github.com/FelixHerrmann/Charts) to confirm!

How do I change a circle to a square ?

You can close the issue!

Multiline chart show only one line chart when x values of datasets are different

#4829 fixes that! ![image](https://user-images.githubusercontent.com/42500484/174615373-9a983eb8-e8d7-4bf0-abab-c193a18698a6.png)

CandleStickChart Correction of maximum element index

Duplicate and a bit different implementation of #4829

3.0.0 (entirely rebuild)

Great! Couldn't test CocoaPods and Carthage, I will catch up on that when it's merged

3.0.0 (entirely rebuild)

I see your point with the renaming, the reason why I did this is that using UIImage[...] in AppKit feels really weird and it's not very Swift-like to have long...

3.0.0 (entirely rebuild)

> If possible, let's work together to break this PR up and incrementally add some of these changes. I think we can include all these changes without causing a breaking...