Felix Engl

Results 8 comments of Felix Engl

Maybe we should finalize `Metdadata`? Because either in the old nor the new implementation it is possible to inherit from the metadata in a meanigful way.

> hi @FelixEngl > > > I hope I don't overdo it with my PRs, but I really did a lot in the last few months. ^^' > > You...

> > hi @FelixEngl > > > I hope I don't overdo it with my PRs, but I really did a lot in the last few months. ^^' > >...

> Hi @FelixEngl > I have to admit that some of your recent changes have made the code slightly more complicated than it was. Are you trying to simplify the...

> > Its working fine, but looks too "wild" and may become problematic to support in the future. > > That's also what I am worried about. Yes, that also...

> What about reverting to the previous version and simply add the lock logic? That wont do it, because the lock would span over too much logic. So I have...

> I have checked out the proposed implementation, and the approach of manually authoring the mapping seems suboptimal. It is very easy to make a mistake and for the mappings...

Hi @sorairolake, no I didn't even know that this was a thing. I'll try to contact them this week when I find the time for it.