Felix Tonnvik

Results 11 comments of Felix Tonnvik

Hi! Yes we have allocated time for this and it should be resolved within a few days.

Hi! Thanks all for the discussion and troubleshooting! I will copy-paste my answer in the PR for visibility: > Hi and thank you for your contribution! > > The fix...

Thanks for your input! The documentation is indeed confusing, we will look into it.

Hi! We are looking into this, mind checking the conflicts that have popped up in the mean time? Thanks in advance

Hi! Thanks for your report! It does indeed seem as the error returned is silently ignored. The culprit seems to reside [here](https://github.com/stakater/Reloader/blob/22ee53ae33d7f95587c1a7860ce31d6bdbc8c2b2/internal/pkg/alerts/alert.go#L37). An initial troubleshooting step could be to iterate...

Yes please open a PR and we can discuss further but immediately fixing this panic seems reasonable even if the "proper" fix might take a little longer.

Hi! Thank you for your suggestion. The current behavior is expected but we do see your point about spamming alerts. The first alternative will require some refactoring to make work,...

@yg1996 Hi! We have discussed this internally and came to the conclusion that by implementing individual workload types, such as the knative service, we open ourselves up to a lot...

Are both triggered from the Reloader? One theory is that one is coming from Kubernetes when changing the Deployment and one is coming from Reloader when detecting the updated ConfigMap.

Okay, I understand what is happening, thanks for added context. I think this feature would be tricky to implement for very little return tbh. The problem comes from the fact...