Thiago Oliveira Santos

Results 61 comments of Thiago Oliveira Santos

Hello! I got this error too, and also notice another thing: This is my controller: ```ts import { HealthCheckResponse } from '../resource/health-dto'; import { Controller, Get } from '@nestjs/common'; import...

I changed the package version of mocha from "*" to "^6.0.0" because last versions of mocha doesn't supports v8.x and v10.x of node, so, the configured pipeline would not work

@benjamingr during our little discussion about the setImmediate, I took a look in the EventEmtter class just before you pointed out that the listeners are called in inclusion order in...

@aduh95 Oh sure! I got the guidelines wrong then, sorry. I thought I need to keep just one commit. I'll not do that again

> > I got the guidelines wrong then, sorry. > > That's not on you, it demonstrates that our docs could use some clarification. Would you be interested in sending...

> Do it on a separate PR: we'll benchmark! Historically we could not change that because modules in the ecosystem relied on `_events`. @mcollina I just did it here https://github.com/nodejs/node/pull/41309...

@benjamingr you are all actually quite responsive, you don't have to apologize for anything. I'm very happy with the attention I got here, It really invites me to contribute more....

Good night, folks. @benjamingr @mcollina @aduh95 I just finished creating a benchmark for the readline iterable and ran it. The generated csv is here: [compare-pr-41309.csv](https://github.com/nodejs/node/files/7787021/compare-pr-41309.csv) And the statistical results are...

> ``` > error: patch failed: lib/events.js:27 > Falling back to three-way merge... > Applied patch to 'lib/events.js' with conflicts. > error: patch failed: lib/events.js:27 > Falling back to three-way...

@aduh95 I did the rebase :) I just ask that, even if it's everything ok, for you folks to wait a little bit before merging it. After some of the...