Fang Yong
Fang Yong
Hi @KarmaGYZ @pnowojski Thanks for your reviews and I'm very sorry for updating this PR so late. I have rebased the code from master and updated the codes in the...
Hi @JingsongLi I have rebase from master for this PR, could you help to review again when you get time? THX
Hi @JingsongLi I have updated this PR, please help to review it again, thanks
Hi @JingsongLi I have rebase master for this PR, please help to review it when you're free, thanks
> We should avoid copying `AbstractFlinkTableFactory`. We can use less codes to fix this. Then maybe we need to create a factory for DataTableSource, it will create DataTableSource for flink-1.14/flink-1.15...
> > > We should avoid copying `AbstractFlinkTableFactory`. We can use less codes to fix this. > > > > > > Then maybe we need to create a factory...
@sunxiaojian Can you split the merge and replace branch in different PRs? I think the operations between them are quite different
Thanks @sunxiaojian @schnappi17 , +1
@JingsongLi We add some benchmark for this issue, please help to review it when you're free, thanks
> The problem is that flink-kafka-connector will be removed from [flink-1](https://issues.apache.org/jira/browse/FLINK-1).18 repo, so the 1.18-snapshot kafka connector are outdate. We should wait for the [flink-1](https://issues.apache.org/jira/browse/FLINK-1).18 release and then modify the...