Ezequiel Postan

icon indicating a website link www.linkedin.com/in/ezequielpostan

icon location You may find what you need in my web site linked below. Feel free to contact me by email (which you can find in my site) for any topic.

Results 24 comments of Ezequiel Postan

Reorganize and document where messages come from

It looks interesting. If I understand correctly, you would like to define on each actor companion's object a `ReceivableMessages` object that lists the messages that can be sent to the...

Reorganize and document where messages come from

> Yes. And also: >* if an actor A sends messages M1, M2,... Mn to an actor B, we should have the following import statement in A: import B.ReceivableMessages.{M1,M2,...Mn}. (We...

Reorganize and document where messages come from

I finally get some time for this. I have a question about something I noticed, do we have any naming convention for actors? For example, to end their names with...

Reorganize and document where messages come from

@ceilican I am applying this change and I can notice one thing about how to import the receivable messages. A class can import the messages for two reasons. 1. To...

Reorganize and document where messages come from

Thanks for the reply @ceilican Let me give an example of each situation: There are actors like `NodeViewHolder` that receive messages that are defined by other Actors, https://github.com/ScorexFoundation/Scorex/blob/master/src/main/scala/scorex/core/NodeViewHolder.scala#L389 For example,...

Reorganize and document where messages come from

This is the WIP PR just in case: https://github.com/ScorexFoundation/Scorex/pull/180 The second commit (https://github.com/ScorexFoundation/Scorex/pull/180/commits/adae5165eea8013d8f0f2b8868ef9919bf9e064b) shows the situation with the `PosForger` actor I should review the case of the first commit (as...

Reorganize and document where messages come from

Thanks for the clarifications @ceilican Now I understand this better. I will review what I did and work it in this way. As you mentioned, I will have to move...

Reorganize and document where messages come from

@ceilican Thanks for the review in the PR. I am getting some failures in my tests (under `examples` project). I have to investigate the cause. It may be related to...

Reorganize and document where messages come from

> I am getting some failures in my tests (under examples project). > I have to investigate the cause. It may be related to the traits with shared messages (but...

Reorganize and document where messages come from

I saw cases where a message is basically forwarded as you mention @ceilican . For example here: https://github.com/ScorexFoundation/Scorex/blob/master/src/main/scala/scorex/core/LocalInterface.scala#L95 But I would need to make a deeper review to check if...