Evan Machusak

Including libraries with conflicting parameter types should trigger a warning

1

Consider: - CQL library A defines a parameter "P" whose type is Interval - CQL Library B defines a parameter "P" whose type is Boolean - A includes B In...

The private keyword should make methods private

1

In library 'a': ``` define private function "Private function"(): true ``` In library 'b': ``` include 'a' called a define "works but should not": a."Private function"() ``` The private access...

The external functions in FHIRHelpers 4.0.1 (https://github.com/cqframework/clinical_quality_language/blob/master/Src/java/quick/src/main/resources/org/hl7/fhir/FHIRHelpers-4.0.1.cql) are not documented. Implementers need specifications on input and expected output. Inline comments in the CQL would be good, but they also deserve...

Consider this CQL: ``` define "DateTime in GMT": DateTime(2022, 8, 8, 1, 30, 0, 0, 0) define "FHIR DateTime in GMT": FHIR.dateTime { value: "DateTime in GMT" } define "To...

Where do we get MIF files?

3

I'm trying to use gmpr to create a library to handle documents with this extension oid: ``` ``` I can barely find any information on this anymore, much less a...

ExpandValueSet is called aggressively

3

Consider this CQL: ``` define function "code in value set"(code Code, codes List): code in codes ``` When this function is called with a value set, e.g.: ``` valueset "Value...

Contexts should have type specifiers

2

The context definition in a library does not have its TypeSpecifier (presumably a NamedTypeSpecifier) populated. ``` "contexts": { "type": "Library$Contexts", "def": [ { "type": "ContextDef", "locator": "7:1-7:15", "name": "Patient" },...

ToList is not implemented according to the spec

2

According to the ELM spec, https://cql.hl7.org/04-logicalspecification.html#tolist > The operator is effectively shorthand for "if operand is null then { } else { operand }". However: https://github.com/cqframework/clinical_quality_language/blob/d10c4ef801a8e160510b2a868c044dea5bdb85c1/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/elm/execution/ToListEvaluator.java When operand is already...

In this HL7 test: `ToDateTime('2014-01-01T12:05:05.955-01:15')` The timezone offset is specified as `-01:15`, which should be `-75` minutes. We are incorrectly creating the `DateTimeOffset` as `-45` minutes. This happens [on this...

Unit conversion is not adhering to the specification

3

Our SDK performs unit equivalency for syntactic date units by normalizing them immediately to their UCUM counterparts. For example, [CqlDate line 208](https://github.com/FirelyTeam/firely-cql-sdk/blob/e69974a2ba15252c0d0fb17c82b9839df49ad07e/Cql/Cql.Primitives/CqlDate.cs#L208) This behavior is contrary to the [Author's Guide...