Islam ElHakmi

Results 12 comments of Islam ElHakmi

@codebytere Nope, I didn't touch any permissions. maybe it has something to do with `npm` version 🤔?

Some Important notes about my last commit : - for [`404` and errors](https://github.com/webpack/webpack-dev-middleware/blob/master/src/middleware.js#L54) express `Content-Type` header is always `text/html; charset=utf-8` but fastify `Content-Type` is `application/json; charset=utf-8`, I tried to set...

@evilebottnawi sure, I'll add the other frameworks in the test as well :smiley:

@evilebottnawi I'm afraid I can't support koa and hapi both are totally different than express. Hapi must have plugins like this: https://hapi.dev/tutorials/expresstohapi/?lang=en_US#creating Koa doesn't pass the traditional (req, res, next)....

@hiroppy I totally agree, I could work on supporting koa and I passed most of the tests but it has problems with changing `publicPath` It'll need so much debugging. So...

@hiroppy I can work on `improve compatibility with other server frameworks` I need more info for `extract webpack hot client from webpack-dev-server` how can I extract it?, about this PR...

@evilebottnawi currently I put `resGetHeader,resSetHeader,getContentLength,getUnknownContentType,sendContent` in `compatibility.js`. `getFilenameFromUrl, getPaths, handleRangeHeaders, ready, setupHooks, setupOutputFileSystem, setupWriteToDisk` are separated. should I add any of them to `compatibility.js` ?

@evilebottnawi not sure why tests are hanging :confused:

This is a demo from my localhost ![testgif](https://user-images.githubusercontent.com/18349358/65523968-51a69d80-deed-11e9-80de-09ab5e1c7c5a.gif) I'm not sure why it's not working on netlify, should I place my changes somewhere else?