Eric

Results 40 comments of Eric

@rudazhan Thanks for doing this! I'm also looking forward to the 0.3 release. In particular for the fixes to spellchecking!

You're almost certainly using new headers with an old library. Can you post the full compile and link commands passing both `-v` and `-Wl,-v`?

> we have a few global non-PODs in tests. these should be removed. I believe your referencing the class-type globals in `benchmark.cc` like `timer_manager` but that's the least of our...

I would much rather bump the required CMake version. CMake is trivial to install on all platforms. There is no reason for people to be using CMake versions that old.

So we should at least bump it to that, but again, it's trivial for users to install newer versions.

LLVM is currently requiring 3.4.3, with the other information provided above it seems like we can agree to bump it to 3.5.1?

I would also settle for `3.4.3` if needed, because if LLVM is getting away with it, so can we. I'm also a large fan of the potentially controversial policy of...

I can't really reproduce with the quick-bench link provided.

`DoNotOptimize()` should do that already.

`DoNotOptimize()` may do other things, but it will also do this. ``` const uint32_t divisor x = 3; DoNotOptimize(&x); ```