Maximilien Colange

Results 6 comments of Maximilien Colange

Fix linkage for `cdef public` functions in C++ mode

I have updated the test to account for the scenario where `__PYX_EXTERN_C` is defined by the end-user, and to remove clang-specific warnings. I think we are good for review. There...

Fix linkage for `cdef public` functions in C++ mode

Any update on this? @scoder Did you have time to review my comments? Or did I miss something?

Functions with C++ return type are `extern "C"`

## Outside Cython - A C function can only have C linkage. Period. `extern` merely indicates that the function is only *declared*, not defined, in the current compilation unit. -...

Functions with C++ return type are `extern "C"`

OMG you are right! I was overthinking the per-function granularity, though I do not think either that the issue is big enough to justify a new keyword. It may be...

add callgrind output format

I can work out the conflicts with `master`, but I think a review would be in order before merging. @benfred would you have some bandwidth to take a look?

sunburst errors with "Non-leaves are not permitted in the dataframe"

I think the dubious check in on the Python side, [`plotly/express/_core.py` lines 1637 -- 1644](https://github.com/plotly/plotly.py/blob/673c19c4eb83709d4344e87976e9fdee697919d3/packages/python/plotly/plotly/express/_core.py#L1637C5-L1645C1).