Shalev Goodman
Shalev Goodman
@SecretPocketCat I actually took this issue because I was getting hit with that exact problem when developing my game for the bevy jam and now with my current project, on...
> > @hymm what do you think would be the best approach for starting to benchmark this solution? > > In the `benches` folder there is a bunch of benchmarks....
> could you commit the `spawn_commands_error_handler` benches? I can try to run them. Sorry, I thought I commited those changes. Added them now. Thank you for the support :)
I ran the tests locally a few times (I did `cargo clean`), everything is green. Is it possible the CI has a cache problem?
> For some reason there's some difference between the errors in CI and some platforms. You should just use the error messages that CI has and accept that your local...
@hymm Did you get a chance to run the benchmark yourself?
> > Did you get a to run the benchmark yourself? > > Going to try and do it today. I ran them before without the new benches and was...
> If there's any changes it's pretty much in the noise. Ran them on main and this pr 3 times each. Depending on which run one could be faster than...
> > How can we proceed for this PR to be reviewed and merged? > > Needs 2 approvals from ECS-SME's, since this is controversial. Community approval can be helpful...