Emil Georgiev comments

Results 22 comments of


                                            Emil Georgiev

test(types/dec_coin): add unit tests for ParseDecAmount

My bad. Fixed. cc @julienrbrt

test(types/address): add unit tests for the file types/address.go

@alpe thank you for your time and your comments.

test(types/address): add unit tests for the file types/address.go

> LGTM! Thanks for driving this forward and all the updates 🏄 I thank you too for your time.

fix(orm)!: properly encode/decode nanoseconds in Duration type

@aaronc if my PR or description are not clear and you have any questions please ask me and I will try to explain better.

fix(orm)!: properly encode/decode nanoseconds in Duration type

First let's start from the beginning. 1. How I found the bug - I saw that we have failing test cases "TestCodec/dur_false" and "TestCodec/dur_false" and I started to investigate why...

fix(orm)!: properly encode/decode nanoseconds in Duration type

> ACK. Makes sense now. Thanks @EmilGeorgiev and apologies for my delay in doing a complete review. This is simpler than the previous implementation and doesn't seem to have any...

fix(orm)!: properly encode/decode nanoseconds in Duration type

> I think the one thing we might need here is a migration path for users of the previous encoding version. @EmilGeorgiev are you using the previous version in production?...

fix(orm)!: properly encode/decode nanoseconds in Duration type

@aaronc DurationV1Codec and TimestampV1Codec with the previous encoded/decoded version are added in this branch. Do you need any other help?

refactor: Decouple database package from the core logic

If you think this makes sense, can I take this issue?

refactor: Prefer strconv.Itoa over fmt.Sprint

If you think this makes sense, can I take this issue?