Eliah Kagan

Results 141 comments of Eliah Kagan

Would it have to be a new PR? Given that [`langchain`](https://pypi.org/project/langchain/) and [`langchain-experimental`](https://pypi.org/project/langchain-experimental/) are [both from this repository](https://github.com/langchain-ai/langchain/tree/master/libs), could this PR be modified accordingly?

It seems to me that for `poetry env use` to use `py --list-paths` on Windows would be a step forward. However, it is not always present, since it is not...

> In terms of error-handling, I am not sure i understand what `git clone` does - does it exit with non-zero status, i.e. officially fails? Git silently falls back to...

Rather than making things more portable, it turns out that, at least in the absence of other changes, this breaks Windows, and possibly macOS! On Windows, compilation still succeeds as...

> What's the point using mac runners for Docker tasks if you can use Linux runners? Currently there are no GitHub-hosted ARM-based Linux runners.

> @EliahKagan already prepared me for this case and I hope he can take a look at this PR as well *[...]* I will try to look at this in...

The new conflict looks to be from #1819 and easily resolvable. #1819 bumped the version on the `setup-wsl` action that this PR comments out.

This was my mistake: the value of `formats` needs either to be a sequence of strings naming specific documentation types, or the string `all`. But I had made it a...

> I think with the next release we can validate that downloads are indeed back. [The download page](https://readthedocs.org/projects/gitpython/downloads/) already has them for the "latest" documentation, since this PR was merged....

As a brief update that I hope to flesh out more at some point: I suspect this is actually related to the problem that `HIDE_WINDOWS_FREEZE_ERRORS` is about on native Windows...