Amrit Kashyap Borah

icon company @devtron-labs icon location Gurgaon icon location 💻 SDE-I @devtron-labs ✨ Completed Google Summer of Code @xfce-mirror 2022 🎓 Computer Science & Engineering IIIT'G | Batch '24

Results 7 comments of Amrit Kashyap Borah

refactor: rb/resource-list.tsx

Noticed that Pagination in fe-common-lib does not have 'pointer' class on the page number, next & previous buttons.

refactor: rb/resource-list.tsx

Regarding prettier formatting, I feel vscode prettier is not recognising the .prettierrc.cjs . If we add .prettierrc instead as a simple json file, the vscode prettier works like node_modules/prettier. So...

refactor: decouple resource-browser clusterSelection view

I haven't refactored the ResourceList.tsx file. Will do that tomorrow.

refactor: decouple resource-browser clusterSelection view

@AbhishekA1509 suggested changes made. Please re-review when not busy.

Bug: (Macos) pressing cmd+c or any shortcut that has cmd in it will break any registered shortcuts unless the window goes blur

I don't mean to ~~brag or~~ be rude but not wrapping it in useCallback and not putting it in the dependency array is only a bad practise but it definitely...

Bug: (Macos) pressing cmd+c or any shortcut that has cmd in it will break any registered shortcuts unless the window goes blur

Hi ! @tlackemann . I opened a little PR for this issue. Thanks.

chore: switch to pnpm

@eshankvaish After checking into this branch just run `git submodules update --init` to pull the submodules