Edward Drapkin

Results 25 comments of Edward Drapkin

I was curious as well, so I figured I could provide a real life benchmark, running a webpack build. This was entirely unscientific and the tests were only run once....

I can't provide the actual source code we use at work, but it's a fairly straightforward React project. You'd get similar results if you copied any react project in there....

Also, your example is **terrible** because it filters the Shoutem Theme stuff through about 100 layers of misdirection, making it a pretty useless demonstration of the theming capacity so much...

I realized I had the wrong prop (changed theme to style in StyleProvider) but I still am having no luck with styleNames: ``` export default class App extends Component {...

I was able to solve this by creating an Objective C class with static methods that called to my problematic module (in this case, Iterable), and then importing and calling...

How about `forbid` and `forbidOnDOM`? `forbidOnDOM` would be an array of strings just like `forbid` except that it's empty by default. I can implement a second, clearer error message this...

I think the flexibility is the same: ``` { "forbid": ["className", "style"], "forbidOnDOM": ["style"] } ``` would achieve the same thing, no? I think that's easier for users to manage...

Ahhhhh, I wasn't even considering that! You make excellent points. Perhaps we could also take this opportunity to allow people the flexibility you imagine? I have two ideas. First, we...

Can't you use a JS file as an .eslintrc.js? It's irrelevant anyway... How does this look? ``` { "property": , "include": "React"|"DOM"|"Both"| } ``` Is `include` a good param name?