Evgeny Ruban comments

Results 25 comments of


                                            Evgeny Ruban

Add support for php 8.1 enums for choice field

@oleg-andreyev didn't work for me... waiting for this PR

[Messenger] Add resettable option for InMemoryTransport

I want it in `6.x` branch too

No matching function call DHT:DHT()

It is just because you have another DHT library installed. Go to your sketches folder, then libraries - delete other library, which contains same DHT.h file, and try again

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

Hey @derrabus, I'm not sure how and where to test that case. Could you help me a bit?

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

@derrabus, done

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

> @wouterj Can you have a look at this? Consuming a rate limiter without actually consuming anything feels like a hack. Is this a scenario we support? I understand that...

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

And, yes, using it before I got the wrong time to retry, it was the time when all tokens will be available, not the first one. With that fix I...

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

> @derrabus > > > @wouterj Can you have a look at this? Consuming a rate limiter without actually consuming anything feels like a hack. Is this a scenario we...

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

> > So then, what about to implement smth like `LimiterInterface::peek()` to get the `RateLimit` object partly using the logic from `LimiterInterface::reserve()` > > That would be a BC break...

[RateLimiter] Fix `RateLimit->getRetryAfter()` return value when consuming `0` or last tokens.

@derrabus any updates? can we add @wouterj as a reviewer here?