DylanRussell
DylanRussell
Yeah I think it can be closed, we basically implemented what was proposed here. Timeout is now inclusive of the retries for example
Closing this now. See https://github.com/open-telemetry/opentelemetry-python/pull/4638 and https://github.com/open-telemetry/opentelemetry-python/pull/4564 for details
BTW I refactored this test a bunch in https://github.com/open-telemetry/opentelemetry-python/pull/4504 if you want to take a look.. Note that this test was duplicated in all the exporters and had a 30...
> The concern this OTEP brings up is that these mechanisms are not present in all the SDKs. And if these SDKs are to add something similar, there is no...
Yeah that is a good question. The other langugage contrib repo's have the GCP resource detector class, and it's weird that this one doesn't. I think putting it here makes...
Not sure why that docs check is failing..
Aha didn't know about the sphinx ignore list thanks. What do you think of adding `ExportStubT` as a public symbol ? I can underscore it, but it'd be inconsistent with...
BTW I bumped pyright up to ==1.1.400 here to get rid of the warning message asking us to upgrade it... Didn't cause any issues AFAICT...
Alright I think it's good to go now.. The changing public symbols are all in the exporter mixin class, which I think it's doubtful people are using directly..
Ok there are 4 broken instrumentations we have to update first.. First https://github.com/open-telemetry/opentelemetry-python/pull/4645 needs to get submitted, so we can start putting EventName directly into the LogRecord instead of as...