Dustin Campbell
Dustin Campbell
Relying on `AppDomainManager` is probably not the best solution since it exposes the fact that we're doing custom AppDomain resolution. IMO, the Locator should push the assembly resolution event handler...
FWIW, it looks like XAML does create their own AppDomain, so this is a sticky problem.
We also do this OmniSharp here: https://github.com/OmniSharp/omnisharp-roslyn/blob/master/src/OmniSharp.Host/MSBuild/Discovery/Providers/MonoInstanceProvider.cs.
It doesn't. OmniSharp ships a small standalone set of MSBuild assemblies as a fallback.
Related: https://github.com/Microsoft/vscode/issues/17691
FWIW, I'm not sure it's very high priority. Also, if we outright move the location, it's a breaking change. We'd probably just want to add another default location.
I'm a little worried about this change. What happens in the following case? 1. Set `"editor.autoClosingBrackets": false` in the VS Code settings. 2. Start with this code; ```C# class C...
Maybe debug and see if it's got the correct span for the format?
For reference, here is the issue tracking the new API on the VS Code side: https://github.com/Microsoft/vscode/issues/28526.
@mrgleba : I cannot repro this on my Mac using your repro steps.  That said, I suspect that the problem you're running into is not related to this particular...