Dragonfly911117

Results 13 comments of Dragonfly911117

![](https://cdn.discordapp.com/attachments/1093938857772322886/1212433247347281941/image.png?ex=65f1d174&is=65df5c74&hm=a4b4979d4c0c489ff982b937e37ea6b9fb16f6bb32d1bdf57a7dc1fe45571a1b&) ![](https://cdn.discordapp.com/attachments/1093938857772322886/1212433246927720488/image.png?ex=65f1d173&is=65df5c73&hm=d9054af4e9c3f995040ff8da38311e6c1cf820cecfa00b802165c503ffc63962&) ![](https://media.discordapp.net/attachments/1093938857772322886/1212433247745876059/image.png?ex=65f1d174&is=65df5c74&hm=8753dc2a3acc62aeffc3517c456985f2193a133c15cb42a2617e9737f11ad252&=&format=webp&quality=lossless&width=1111&height=701) The Update seems not working.

Do we have any news about this feature? Can really use it.

Why am I asked to review this again? Thought I've already approved this.

> It work but not elegant [NTUT-FUCK-PTSD@c463129](https://github.com/NTUT-FUCK-PTSD/practical-tools-for-simple-design/commit/c4631295eacd13b3e0e9ebe45cf841f4f80874af) > > Original code `SDL_Delay(static_cast(frameTime - Util::Time::GetDeltaTime()));` is incorrect , milliseconds-seconds We are working on that. Should have the PR open this week.

> > It work but not elegant [NTUT-FUCK-PTSD@c463129](https://github.com/NTUT-FUCK-PTSD/practical-tools-for-simple-design/commit/c4631295eacd13b3e0e9ebe45cf841f4f80874af) > > Original code `SDL_Delay(static_cast(frameTime - Util::Time::GetDeltaTime()));` is incorrect , milliseconds-seconds > > We are working on that. Should have the PR...

- [ ] #78

This is caused by the `string_view PTSD_Config::TITLE` pointing to bad address. Will be fixed in days.

This would also happen when having `toggle_workspace_on_refocus` is set to true and opening a window that binded to current workspace. For example, with the config following, opening a new vivaldi...

> > why does the diff look like this? is there something wrong w/ the linebreak or something? > > 我今天使用CMAKE(version 4.1.0)建置時會出現錯誤,上面的提示是寫說4.1.0已不再支援3.5.0以下的cmake(SDL2的cmakelist 要求的版本是3.0.0),所以我新增了一個判斷是當版本為4.0.0以上時退版成3.5.0 我覺得他指的是你的 CMakeLists.txt 的 diff 看起來有 tab/space 或...