Donovan Daniels
Donovan Daniels
unsure if when transforming days to seconds, if we should consider an explicitly provided `undefined` a value we shouldn't override (current code treats it as such)
Took all previous changes and squashed them to remove some old commits left behind from previous force pushing, as trying to drop them with a rebase was giving me hell
Converted to draft until #1303 is merged
Don't mind the force pushing mess, I somehow managed to cherry pick the new dev commits instead of merging them some time back, they've been properly merged in now
you left some interfaces dangling around (`UserProfile`/`UserSettings`) and a bunch of `GroupChannel` remnants And some very old bots can technically be in Group Channels iirc, I assume we aren't considering...
`Client#getChannel` still checks for group channels, which no longer exist various remnants of Group Channels have been left dotted around
> > `Client#getChannel` still checks for group channels, which no longer exist > > various remnants of Group Channels have been left dotted around > > Is it worth it...
More things I've just found, the event definitions for `callCreate`, `callDelete`, `callRing` & `callUpdate` are still floating around
I've gone back through some documentation, and now see that GroupChannels are not purely userbot features. ~~Any removals or changes should be undone.~~ Correction: The removals from they gateway are...
I didn't say they could join them, they can't be received over the gateway sure but they can be retrieved from rest just fine if the bot created it