Feng Zhu

Results 17 comments of Feng Zhu

@jinxing64 @xy2953396112 I have been kind of busy recently. I'm glad that you can continue this work. Thanks!

Hi, @gr4ve, could you please rebase this work? We have encountered use case that varargs UDF can play important role. As we use Calcite to connect different datasources, we need...

Thanks @zabetak, I have not ever tried the fix in our environment. But the PR is OK to me. I do not have any further comments.

Hi @gr4ve, to solve the conflicts, you need to rebase this pr on latest calcite/master branch.

According to the current semantics in `SqlUtil#isNullLiteral`, we can replace the word "constant" with "null" here.

@jinxing64 I ever consider to do in that way. However, I found there are already 5 `AggFinder`s in `SqlValidatorImp`. I'm not sure whether it is a good choice. So I...

@XuQianJin-Stars I'm refactoring the codegen component now and try to unify the inconsistencies buried under current codegen framework. This PR need to do more work. I will update it these...

`ScalarFunctionImpl` determines NullPolicy based on annotations, while `TableFunctionImpl` sets `NullPolicy=ANY` by default for all cases. However, according to the javadoc in `TableFunction`, `null` arguments are allowed. ``` /** * Returns...

Hi, @julianhyde, Current now, I adopt the approach as that in `ScalarFunctionImpl` to dynamically determines the `NullPolicy` based on annotation. But as shown in `TableFunctionTests`, it seems not to be...