Dom G.

I have marked this as WIP since there is still work to be done here: * Look into refactoring more methods appearing in the list of methods in #1099 *...

> Looking at the method in 'Key' the method that performs the equality check on a byte array `private static boolean isEqual(byte[] a1, byte[] a2)` is already optimized for Accumulo...

A few more methods were found ([details](https://github.com/apache/accumulo/issues/1099#issuecomment-1198342829)). I'll look into those now, before this is merged.

> A few more methods were found ([details](https://github.com/apache/accumulo/issues/1099#issuecomment-1198342829)). I'll look into those now, before this is merged. Never mind. Took a look and I don't think those methods will be...

I have refactored `Key.equals()` in a way that makes it not show up in the hot methods list any more. Here is the method after refactoring: ```java public boolean equals(Key...

In 89a2f32 I added [the equals method described above](https://github.com/apache/accumulo/pull/2811#issuecomment-1198615354). This updated method does not appear on the hot methods list.

I've run an updated version of [the benchmark](https://issues.apache.org/jira/secure/attachment/12829691/benchmark.tar.gz) from [the original jira ticket](https://issues.apache.org/jira/browse/ACCUMULO-4468) and the results I received seem significant ``` Benchmark Mode Cnt Score Error Units MyBenchmark.customDom thrpt 25...

@EdColeman, I think you are understanding things correctly. The code I posted above was from the original ticket and I had overlooked the points you have made. I'll work on...

> Looking at the method in 'Key' the method that performs the equality check on a byte array private static boolean isEqual(byte[] a1, byte[] a2) is already optimized for Accumulo...

> I am confused with the in the context of #2811 are any changes needed? No changes are _needed_ in the sense that they don't fix any bugs or change...